[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service
- To: mulix <mulix(at-nospam)actcom.co.il>
- Subject: Re: [pptp-devel] RFC: required patch to pptp 1.0.3 for israeli adsl service
- From: Rein Klazes <rklazes(at-nospam)xs4all.nl>
- Date: Tue, 13 Nov 2001 17:33:16 +0100
- Cc: <pptpclient-devel(at-nospam)lists.sourceforge.net>, <linux-il(at-nospam)linux.org.il>
- Delivered-To: linux.org.il-linux-il@linux.org.il
- In-Reply-To: <Pine.LNX.4.33.0111122350500.8346-100000@alhambra.merseine.nu>
- Organization: -
- References: <Pine.LNX.4.33.0111122350500.8346-100000@alhambra.merseine.nu>
- Reply-To: rklazes(at-nospam)xs4all.nl
- Sender: linux-il-bounce(at-nospam)cs.huji.ac.il
On Tue, 13 Nov 2001 00:04:19 +0200 (IST), you wrote:
> +#else /* PPTP_BEZEQ_ISRAEL is defined */
> + {
> + PPTP_HEADER_CTRL(PPTP_OUT_CALL_RQST),
> + 0, /* hton16(call->callid) */
> + 0, /* hton16(call->sernum) */
I don't understand why you need this: call->callid and call->sernum
*are* zero for the first and only connection pptp_ctrl can make.
> + hton32(PPTP_BPS_MIN), hton32(PPTP_BPS_MAX),
> + hton32(PPTP_BEARER_DIGITAL), hton32(PPTP_FRAME_ANY),
> + hton16(PPTP_WINDOW), 0, hton16(PPTP_HOSTNAME_LEN),0, PPTP_HOSTNAME, {0}
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
If I'm not mistaken you are filling the "phonenumber" field here. This
can be specified on the command line with the option "--phonenumber".
Perhaps some other fields that you require to be changed may be
specified this way as well?
> + };
> +#endif
>
> /* fill in the phone number if it was specified */
> if( phonenr ){
which is done here.
> @@ -473,6 +485,22 @@
> }
> }
>
> +static void
> +pptp_set_link(PPTP_CONN* conn, int peer_call_id)
> +{
> + struct pptp_set_link_info packet = {
> + PPTP_HEADER_CTRL(PPTP_SET_LINK_INFO),
> + hton16(peer_call_id),
> + 0,
> + 0xffffffff,
> + 0xffffffff};
> +
> + if (pptp_send_ctrl_packet(conn, &packet, sizeof(packet))) {
> + log("pptp_set_link() packet sending succesfull");
> + pptp_reset_timer();
> + }
> +}
>
> @@ -650,6 +691,7 @@
> call->peer_call_id = ntoh16(packet->call_id);
> call->speed = ntoh32(packet->speed);
> pptp_reset_timer();
> + pptp_set_link(conn, call->peer_call_id);
> if (call->callback!=NULL) call->callback(conn, call, CALL_OPEN_DONE);
> log("Outgoing call established (call ID %u, peer's call ID %u).\n",
> call->call_id, call->peer_call_id);
Strange for the set-link-info message to be sent at a point in time
when pppd hasn't even been started creating one yet. The pptp server
that requires this, must be really broken.
Rein.
--
Rein Klazes
rklazes@xs4all.nl
=================================================================
To unsubscribe, send mail to linux-il-request@linux.org.il with
the word "unsubscribe" in the message body, e.g., run the command
echo unsubscribe | mail linux-il-request@linux.org.il