[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: netkit-ftp-0.17



On Tue, 24 Jul 2001, Dan Kenigsberg wrote:


  Actually, it's more odd than you'd think :)

  I recompiled the ftp netkit without changes, that is, with unsigned
short, and I used the ftp I compiled, and that works, while the
netkit-ftp-0.7-7 based ftp doesn't. This leads me to suspect a compiler
bug, or some weirdity on the system that created the packages.

  I jumped the gun too soon with the short vs. int thing, since I didn't
try the self compiled binary, assuming it would work the same as the one
RedHat released, so I just changed, saw it works, and wrongly deduced that
caused it.

  Alan, can you bounce this within RH ?

thanks,

--Ariel

> Odd. I'm pretty sure unsigned int goes up to 65535 (16bit).
> This is the correct span of port numbers. The question whether it
> was smart to allocate so few is left open.
> 
> test this:
> 
> #include <stdio.h>
> 
> int main(void)
> {
> unsigned short i;
> 
> i = -1;
> 
> printf("%d\n", i);
> }
> 
> 
> >  Hi guys,
> >
> >  Someone decided to use "unsigned short" for the ftp peer port number,
> > so you cannot ftp hosts with port larger than 32767. I don't know who
> > deals with it among you guys, but I am sureyou can bounce it to the right
> > person:
> >
> > [root@fireball netkit-ftp-0.17]# diff -u ftp/cmds.c.orig ftp/cmds.c
> > --- ftp/cmds.c.orig   Tue Jul 24 17:15:13 2001
> > +++ ftp/cmds.cTue Jul 24 17:12:28 2001
> > @@ -190,7 +190,7 @@
> >setpeer(int argc, char *argv[])
> >{
> >       char *host;
> > -     unsigned short port;
> > +     unsigned int port;
> >
> >       if (connected) {
> >               printf("Already connected to %s, use close first.\n",
> >
> >
> > thanks,
> >
> > --Ariel
> >
> >--
> > Ariel Biener
> > e-mail: ariel@post.tau.ac.il
> > PGP(6.5.8) public key http://www.tau.ac.il/~ariel/pgp.html
> >
> >
> > =================================================================
> > To unsubscribe, send mail to linux-il-request@linux.org.il with
> > the word "unsubscribe" in the message body, e.g., run the command
> > echo unsubscribe | mail linux-il-request@linux.org.il
> >
> 
> 
> =================================================================
> To unsubscribe, send mail to linux-il-request@linux.org.il with
> the word "unsubscribe" in the message body, e.g., run the command
> echo unsubscribe | mail linux-il-request@linux.org.il
> 

--
Ariel Biener
e-mail: ariel@post.tau.ac.il
PGP(6.5.8) public key http://www.tau.ac.il/~ariel/pgp.html


=================================================================
To unsubscribe, send mail to linux-il-request@linux.org.il with
the word "unsubscribe" in the message body, e.g., run the command
echo unsubscribe | mail linux-il-request@linux.org.il