[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: Annoucement of FriBidi 0.1.0 - A free BiDi library
> FriBidi may be found at:
>
> http://imagic.weizmann.ac.il/~dov/freesw/FriBidi
>
Good thing. Greak work.
First impressions:
Makefile doesn't handle correctly includes for glib. You need to add
`glib-config --cflags` to CPPFLAGS. Maybe also `glib-config --libs` to
LDFLAGS, though now it's not necessary, but in the future might well be.
test program doesn't accept input from stdin. It is not good. Just put
something like:
*** test_fribidi.c_old Tue Jan 12 00:08:55 1999
--- test_fribidi.c Tue Jan 12 11:33:36 1999
***************
*** 66,76 ****
}
if (argp >= argc) {
! fprintf(stderr, "Need name of file!\n");
! exit(-1);
}
- fn = argv[argp++];
- IN = fopen(fn, "r");
while(fgets(S_, sizeof(S_), IN))
{
--- 66,76 ----
}
if (argp >= argc) {
! IN = stdin;
! } else {
! fn = argv[argp++];
! IN = fopen(fn, "r");
}
while(fgets(S_, sizeof(S_), IN))
{
It would be not bat also to have a "clean" output mode - just output
conversion results, without source string and =>.
Not about library itself: it doesn't parse correctly numbers like "-2":
* HERE WE TEST -2 AND 2+3 => 2+3 DNA 2- TSET EW EREH *
Shouldn't it be "-2" in the second case?
Also,
<h123>SAALAM</h123> => <h123>MALAAS</h123>
but,
ABC <h123>SAALAM</h123> => <h123/>MALAAS<h123> CBA
This may or may not be a problem. I had problems with such cases, but this
might be Unicode-correct.
TEST 2*3 HERE => EREH 3*2 TSET
This seems to be a problem with character types. * should be as + and -,
IIRC.
The same with
TEST 2>3 HERE => EREH 3<2 TSET
though this is more fine point... I think, it should still be 2>3, though
Unicode may think otherwise, I just haven't a book with me and my BiDi
implementation does the same.
--
frodo@sharat.co.il \/ There shall be counsels taken
Stanislav Malyshev /\ Stronger than Morgul-spells
phone +972-2-6245112 /\ JRRT LotR.
http://sharat.co.il/frodo/ whois:!SM8333